[DPE-2289] [DPE-2388] Upgrade from 14/stable and add integration tests #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unit initialisation
This reverts commit c249b44.
…into dpe-2289-upgrade-integration-tests
marceloneppel
changed the title
marceloneppel
changed the title
dragomirp
reviewed
Oct 12, 2023
dragomirp
reviewed
Oct 12, 2023
dragomirp
approved these changes
Oct 12, 2023
dragomirp
reviewed
Oct 12, 2023
| assert primary_name == f"{DATABASE_APP_NAME}/0" | ||
|
|
||
| local_charm = await ops_test.build_charm(".") | ||
| fault_charm = Path("/tmp/", local_charm.name) |
There was a problem hiding this comment.
Fails in CI, we should most probably return a path here: https://github.com/canonical/postgresql-k8s-operator/blob/dpe-2289-upgrade-integration-tests/tests/integration/conftest.py#L74
There was a problem hiding this comment.
Good catch. I'm gonna revisit this later.
taurus-forever
approved these changes
Oct 13, 2023
|
@marceloneppel are we ready to merge this? I want to promote it to the |
Merging now. |
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
canonical#210) * Added initial upgrade implementation * Minor fixes * Adjusted code to correctly update the upgrade stack and speed up the unit initialisation * Minor fixes * Updated the code with the new library * Fixed upgrade logic to switchover to unit zero and added unit tests * Added backup creation check * Rollback dependencies * Fixed dependencies * Minor fixes * Final fixes * Removed upgrade integration tests * Pin charmcraft revision * Remove charmcraft pin * Removed hashes from requirements * Revert "Removed upgrade integration tests" This reverts commit c249b44. * Renamed overriden method * Upgraded test * Added replication health check and rock dependency * Comment test * Add additional upgrade logic for stable revision * Fix partially the upgrade from stable * Fix exporter startup * Fix metrics service start * Revert tests * Format * Lint * Add test for upgrade from stable * Add upgrade test * Minor fixes * Fix unit tests * Fix unit tests patches * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We cannot upgrade from
14/stable.There are no integration tests for the upgrade process.
Solution
Add logic to correctly upgrade from
14/stable.The monitoring user and its credentials are being created when upgrading from
14/stable(which doesn't have that user).This also fixes the upgrade from a single unit cluster and updates the workload version.
Add tests that check if the upgrade succeeds, by using some assertions related to the upgrade lib and ensure that no writes from an application are lost during the upgrade process.