Added kubeflow pipelines driver rock image #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks @BON4 ! Just a tiny change in the version, other than that LGTM!
I have tested this rock by:
- Building the rock -> Success
- Running the image in a container and looking for the right files -> Success
$ docker run --rm -ti --entrypoint /bin/bash driver:0.1
_daemon_@f49948563229:/$ ls /bin/driver
/bin/driver
_daemon_@f49948563229:/$ ls /third_party/licenses.csv
/third_party/licenses.csv
_daemon_@f49948563229:/$ ls /third_party/NOTICES
cloud.google.com github.com go.opencensus.io gocloud.dev golang.org google.golang.org gopkg.in k8s.io sigs.k8s.io
- Executing the binary -> OK (the binary won't do anything w/o the proper args)
_daemon_@f49948563229:/$ /bin/driver
F1202 23:14:39.798672 9 main.go:79] KFP driver: argument --type must be specified
_daemon_@f49948563229:/$ /bin/driver --type CONTAINER
I1202 23:16:02.017136 20 main.go:108] input ComponentSpec:{}
I1202 23:16:02.017572 20 main.go:121] input ContainerSpec:{}
I1202 23:16:02.017661 20 main.go:136] input kubernetesConfig:{}
F1202 23:16:02.017926 20 main.go:79] KFP driver: failed to get namespace in Pod: open /var/run/secrets/kubernetes.io/serviceaccount/namespace: no such file or directory
DnPlas
approved these changes
Dec 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is re-open request for #109.
Logs
Using kfp-operators. Modified kfp-api/config.yaml. Replaced "gcr.io/ml-pipeline/kfp-driver" with "vyurchenko581/kfp-driver:2.2.0".
Additionally, the default port for KUBEFLOW_LOCAL_HOST has been changed from 8080 to 8081 due to its unavailability on my local machine, as it is already in use.
Juju status after all tests passed:
Logs of passed integration tests
tox -vve bundle-integration-v2 -- --model kubeflow --bundle=./tests/integration/bundles/kfp_latest_edge.yaml.j2 --keep-models: