Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial README, with sections commented out that aren't yet true #3

Merged
merged 18 commits into from
Jun 27, 2024

Conversation

mthaddon
Copy link

Applicable spec: N/A

Overview

A basic README.

Rationale

Update the README.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

No charmhub docs yet.

@mthaddon mthaddon added documentation Improvements or additions to documentation trivial labels Jun 26, 2024
@mthaddon mthaddon requested a review from a team as a code owner June 26, 2024 08:01
@mthaddon mthaddon marked this pull request as draft June 26, 2024 08:02
@mthaddon mthaddon marked this pull request as ready for review June 26, 2024 08:41
merkata
merkata previously approved these changes Jun 26, 2024
README.md Outdated Show resolved Hide resolved
Co-authored-by: Mariyan Dimitrov <mariyan.dimitrov@gmail.com>
nrobinaubertin
nrobinaubertin previously approved these changes Jun 26, 2024
README.md Outdated Show resolved Hide resolved
merkata
merkata previously approved these changes Jun 27, 2024
Copy link
Collaborator

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthaddon mthaddon dismissed stale reviews from merkata and nrobinaubertin via 4d52276 June 27, 2024 12:41
README.md Outdated Show resolved Hide resolved
Thanhphan1147
Thanhphan1147 previously approved these changes Jun 27, 2024
Copy link

Test coverage for d392bda

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      14      0      2      0   100%
----------------------------------------------------------
TOTAL             14      0      2      0   100%

Static code analysis report

Run started:2024-06-27 13:38:54.838410

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 76
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthaddon mthaddon merged commit c6e6404 into main Jun 27, 2024
17 checks passed
@mthaddon mthaddon deleted the readme branch June 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants