Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove templated metadata.yaml and populate initial charmcraft yaml #2

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

mthaddon
Copy link

@mthaddon mthaddon commented Jun 19, 2024

Applicable spec: N/A

Overview

Remove templated metadata.yaml and populate initial charmcraft.yaml so that very basic charm can be built. Also update so basic lint and unit tests pass.

Rationale

Allows us to build a charm on 24.04.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

No documentation for charmhub yet, that'll come later once we have a charm that actually deploys a workload.

@mthaddon mthaddon requested a review from a team as a code owner June 19, 2024 10:05
@mthaddon mthaddon marked this pull request as draft June 19, 2024 12:34
Copy link

Test coverage for d53c393

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      14      0      2      0   100%
----------------------------------------------------------
TOTAL             14      0      2      0   100%

Static code analysis report

Run started:2024-06-20 06:41:47.918695

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 76
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mthaddon mthaddon marked this pull request as ready for review June 26, 2024 07:29
Copy link

@javierdelapuente javierdelapuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/integration/test_charm.py Show resolved Hide resolved
@mthaddon mthaddon merged commit b1cf2e8 into main Jun 26, 2024
17 checks passed
@mthaddon mthaddon deleted the charmcraft branch June 26, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants