Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ErrorStatus fix #927

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

mkalcok
Copy link

@mkalcok mkalcok commented Apr 24, 2023

Add ErrorStatus so that getting Unit/App.status when the status is "error" does not raise.

This is merely a backport of #875 (that fixes #874) into the 1.5-maintenance branch.

Checklist

  • Have any types changed? If so, have the type annotations been updated?
  • If this code exposes model data, does it do so thoughtfully, in a way that aids understanding?
  • Do error messages, if any, present charm authors or operators with enough information to solve the problem?

QA steps

added tests.

Bug reference

Backports fix for #874 into the 1.5-maintenance branch.

Changelog

@mkalcok
Copy link
Author

mkalcok commented Apr 24, 2023

CI failures do not seem to be related to the code changes. Fix for the CI proposed in #928

@benhoyt
Copy link
Collaborator

benhoyt commented Apr 25, 2023

This looks fine, thanks for that. Would you mind bringing your branch up to date now that #928 is merged? And then I can merge this and release 1.5.5.

Add ErrorStatus so that getting Unit/App.status when the status is
"error" does not raise.

Co-authored-by: Ben Hoyt <ben.hoyt@canonical.com>
@mkalcok mkalcok force-pushed the ErrorStatus-backport branch from 74ccecd to fe7e40c Compare April 25, 2023 10:00
@mkalcok
Copy link
Author

mkalcok commented Apr 25, 2023

Thanks for the review. I rebased the PR branch.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me to backport this fix to the 1.5 branch -- thanks.

@benhoyt benhoyt merged commit 5bbc50f into canonical:1.5-maintenance Apr 25, 2023
@benhoyt
Copy link
Collaborator

benhoyt commented Apr 25, 2023

@mkalcok This is now released in ops version 1.5.5, which you can install with pip install ops==1.5.5.

@mkalcok
Copy link
Author

mkalcok commented Apr 25, 2023

Awesome, thank you for fast release :)

@mkalcok mkalcok deleted the ErrorStatus-backport branch April 25, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants