docs: add a how-to for setting open ports #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is this replaces the tutorial chapter.
james-garner-canonical
approved these changes
Feb 14, 2025
dwilding
reviewed
Feb 17, 2025
dwilding
reviewed
Feb 17, 2025
dwilding
reviewed
Feb 17, 2025
dwilding
reviewed
Feb 17, 2025
dwilding
reviewed
Feb 17, 2025
dwilding
reviewed
Feb 17, 2025
Comment on lines
+57
to
+58
| To verify that the correct ports are open in an integration test, deploy your | ||
| charm as usual, and then try to connect to the appropriate ports. |
There was a problem hiding this comment.
Nice 😄 In this sense, integration tests are so much simpler...!
dwilding
reviewed
Feb 17, 2025
dwilding
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
I've finished reviewing @tonyandrewmeyer, I think this is going to be a helpful new doc. Thanks!
Co-authored-by: Dave Wilding <tech@dpw.me>
Co-authored-by: Dave Wilding <tech@dpw.me>
Co-authored-by: Dave Wilding <tech@dpw.me>
Co-authored-by: Dave Wilding <tech@dpw.me>
Co-authored-by: Dave Wilding <tech@dpw.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic how-to guide that covers using
Unit.set_portsto set which ports are open, and unit and integration tests for such.The intention is that this replaces the tutorial chapter (see #1511).