Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use explicit framework param instead of *args #1523

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

benhoyt
Copy link
Collaborator

@benhoyt benhoyt commented Jan 8, 2025

A while back we decided to recommend using an explicit framework parameter instead *args to a charm's __init__. We've updated charmcraft init templates, but we forgot a few places in our docs. Update them to match here.

Preview

@benhoyt
Copy link
Collaborator Author

benhoyt commented Jan 8, 2025

test-real-pebble failed once here. It looks like test_checks_and_health is timing-sensitive and should be improved. Re-running for now, and if it happens again we should open an issue and fix.

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@dwilding dwilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@benhoyt benhoyt merged commit cece866 into canonical:main Jan 9, 2025
33 checks passed
@benhoyt benhoyt deleted the avoid-self.framework branch January 9, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants