Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use the actual poetry command, rather than manually tweaking the file #1443

Merged

Conversation

tonyandrewmeyer
Copy link
Contributor

When handling charms that used poetry, the workflow would do a clone of the ops repo, tweak the poetry.lock file to include it and then re-lock. This leaves a copy of the ops repo around, and sometimes the ops tests get picked up by pytest, which is not what we want here.

The PR changes this to use the proper poetry add functionality to add the appropriate version of ops, in the same way that the requirements.txt files are updated.

Additional related fixes:

  • The test runs for the charmcraft profiles also had the operator clone but never used it, so remove that.
  • The charmcraft profile can safely run the static checks (since the charms are so minimal), and that would have caught an issue previously, so add that.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tonyandrewmeyer tonyandrewmeyer merged commit 1ebec7b into canonical:main Nov 1, 2024
31 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the fix-published-charm-ci branch November 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants