Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin the dev requirements to major.minor compatible #1054

Merged
merged 6 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/framework-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ jobs:
- uses: actions/checkout@v3
- name: Set up Python 3
uses: actions/setup-python@v2

with:
python-version: '3.11'
- name: Install tox
run: pip install tox~=4.2

Expand Down Expand Up @@ -98,6 +99,8 @@ jobs:
- uses: actions/checkout@v3
- name: Set up Python 3
uses: actions/setup-python@v2
with:
python-version: '3.11'

- name: Build
run: python setup.py sdist
Expand Down
2 changes: 1 addition & 1 deletion ops/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1855,7 +1855,7 @@ def _config_set(self, key: str, value: Union[str, int, float, bool]):
'Incorrectly formatted `options.yaml`: `type` needs to be one '
'of [{}], not {}.'.format(', '.join(self._supported_types), declared_type))

if type(value) != self._supported_types[declared_type]:
if type(value) is not self._supported_types[declared_type]:
raise RuntimeError('Config option {} is supposed to be of type '
'{}, not `{}`.'.format(key, declared_type,
type(value).__name__))
Expand Down
22 changes: 11 additions & 11 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
isort==5.11.4
autopep8==1.6.0
flake8==4.0.1
flake8-docstrings==1.6.0
flake8-builtins==2.1.0
pyproject-flake8==4.0.1
pep8-naming==0.13.2
pytest==7.2.1
isort~=5.11
autopep8~=1.6
flake8~=6.1
flake8-docstrings~=1.7
flake8-builtins~=2.1
pyproject-flake8~=6.1
pep8-naming~=0.13
pytest~=7.2
pyright==1.1.317
pytest-operator==0.23.0
coverage[toml]==7.0.5
typing_extensions==4.2.0
pytest-operator~=0.23
coverage[toml]~=7.0
typing_extensions~=4.2

-r requirements.txt