passing k8s_resources to pod.set_spec() requires a dict with a single key "kubernetesResources"

[axinojolais]

Hi,

If I understand things correctly, one needs to do the following to use pod.set_spec() :

myspec = <whatever>
myresources = <resources>

self.model.pod.set_spec(myspec, k8s_resources={'kubernetesResources': myresources})

Is there any reason we can't call it like this ?

self.model.pod.set_spec(myspec, k8s_resources=myresources)

And then the framework would add embed the resources in a dict under the kubernetesResources key ? Can this dict have any other item ?

Thanks

[stub42]

If we want to fix this, now is the time since we haven't released a version where the second argument to set_spec actually works, but it will start working when Juju 2.8.2 is released RSN.

[axinojolais]

If we want to fix this, now is the time since we haven't released a version where the second argument to set_spec actually works, but it will start working when Juju 2.8.2 is released RSN.

Perhaps the code could check the existence of a kubernetesResources key is the given dict, and if it's there mimic the current behaviour ?

[jameinel]

Unfortunately this is broken design from the underlying Juju pod-spec-set command. I'd much rather that was fixed rather than perpetuate workarounds for broken behavior up the stack. that said, if we need to we could workaround it here. John

…

On Thu, Aug 20, 2020, 07:39 Beaujolais ! ***@***.***> wrote: Hi, If I understand things correctly, one needs to do the following to use pod.set_spec() : myspec = <whatever> myresources = <resources> self.model.pod.set_spec(myspec, k8s_resources={'kubernetesResources': myresources}) Is there any reason we can't call it like this ? self.model.pod.set_spec(myspec, k8s_resources=myresources) And then the framework would add embed the resources in a dict under the kubernetesResources key ? Can this dict have any other item ? Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#387>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRQ7LL7DULLP7AMYV6OQ3SBUKRNANCNFSM4QGAFVMQ> .

[jnsgruk]

I'm going to close this for now; the pod_spec style of charms are not receiving as much attention any more in favour of "sidecar charms".