bridges: implement vlans, port-vlans, vlan-filtering and vlan-default-pvid options #540
+632
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a followup to #127 .
As described in #127:
Implements the vlans & port-vlans option keys for bridges, as required by the "NetworkManager readwrite plugin" spec. Currently only supports the nm backend.
I've rebased the old PR onto the current
main
and it seems to work OK (at least the tests are passing). Additionally added thevlan-filtering
bool that can be forcedtrue
even if novlans
are defined (as described by @chdxD1 in this comment here.Right now I am starting to work onnetworkd
backend. However decided to create this draft PR to enable an early review and to just let others know that I am working on this.I've added
vlan-default-pvid
to set default PVID for a bridge andnetworkd
backend so i think the PR is ready. :)make check-coverage
fails for me incodestyle
test withinnetplan/_build/meson-private/pycompile.py
, which is Meson's file so I believe this is out of scope here, therefore checkingmake check-coverage
in the checklist as passed.I can also see that GitHub actionI think Ubuntu's repositories were fixed already.NetworkManager Autopkgtest / lxd-network-manager
is failing due tolibc6-dev : Depends: libc6 (= 2.39-0ubuntu8.3) but 2.39-0ubuntu8.4 is to be installed
but it also seems to be an issue with Ubuntu repositories I think.Checklist
make check
successfully.make check-coverage
).