Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the *correct* xcursor cursor names on decorations #3777

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Feb 25, 2025

We don't have all the right mir_*_cursor_name constants, just bypass them and use the right names where necessary

Fixes: #3776

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner February 25, 2025 14:23
@AlanGriffiths AlanGriffiths marked this pull request as draft February 25, 2025 14:24
@AlanGriffiths AlanGriffiths marked this pull request as ready for review February 25, 2025 15:10
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the default cursor here?

Otherwise looks legit.

@AlanGriffiths
Copy link
Collaborator Author

Why do you remove the default cursor here?

I deduplicated the default cursor as the second copy isn't ever used

@Saviq Saviq added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 02c7506 Feb 25, 2025
52 of 66 checks passed
@Saviq Saviq deleted the fix-decoration-cursors branch February 25, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSDs] the cursor icons for top-left and bottom-left resize are wrong
2 participants