Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented subsurface support for touches #350

Merged
merged 1 commit into from
Apr 30, 2018
Merged

implemented subsurface support for touches #350

merged 1 commit into from
Apr 30, 2018

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Apr 30, 2018 •
edited by AlanGriffiths
Loading

Pretty simple, but completely untested (don't have a touchscreen running Linux on me). (Fixes #347)

@wmww wmww mentioned this pull request Apr 30, 2018
Closed
@AlanGriffiths
Copy link
Collaborator

Seems to work. Will read the code tomorrow.

AlanGriffiths
AlanGriffiths approved these changes Apr 30, 2018
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

bors bot added a commit that referenced this pull request Apr 30, 2018
@bors
Merge #350
b20182a 
350: implemented subsurface support for touches r=AlanGriffiths a=wmww

Pretty simple, but completely untested (don't have a touchscreen running Linux on me). (Fixes #347)

Co-authored-by: William Wold <william.wold@canonical.com>
@bors
Copy link
Contributor

bors bot commented Apr 30, 2018

Build succeeded

@bors bors bot merged commit 9ebc56d into master Apr 30, 2018
@bors bors bot deleted the subsurface-touches branch April 30, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmww @AlanGriffiths