Subsurface input (finally) #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 26, 2018 22:53
AlanGriffiths
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
Keyboard and mouse input seems to be working on subsurfaces, but not touch input. Unless that's trivial, I'm happy to land this pending a separate fix.
Test case:
- Start gedit.
- Touch "Open"
- Touch a recent doc. Expect it opens, actual nothing
- Touch "Other Document...". Expect open dialog, actual nothing.
| @@ -110,13 +112,20 @@ void mf::WlPointer::handle_event(MirPointerEvent const* event, WlSurface* surfac | |||
| auto point = Point{mir_pointer_event_axis_value(event, mir_pointer_axis_x), | |||
| mir_pointer_event_axis_value(event, mir_pointer_axis_y)}; | |||
| auto transformed = surface->transform_point(point); | |||
| handle_enter(transformed.first, transformed.second); | |||
| handle_frame(); | |||
| if (transformed) | |||
There was a problem hiding this comment.
Just a style nit: I prefer to restrict the scope of everything (in this case transformed). Vis:
if (auto const transformed = surface->transform_point(point))
I know it makes little difference here (and won't block on it).
|
On further thoughts: let's land this before the weekend, I'll file a bug for about the touch issues. bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for subsurfaces to get mouse input.