-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix input configuration implementation #3407
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
- Coverage 77.31% 77.27% -0.05%
==========================================
Files 1075 1075
Lines 68345 68401 +56
==========================================
+ Hits 52841 52854 +13
- Misses 15504 15547 +43 ☔ View full report in Codecov by Sentry. |
18705e6
to
806884a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, but overall looks good
a12b785
to
4f23c1d
Compare
Co-authored-by: Matthew Kosarek <matthew@matthewkosarek.xyz>
4f23c1d
to
0613d64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Some of this code was written with an incorrect understanding (that multiple click and scroll modes could be active at once).
That required an API change.
Also some improved logging and tidying up.
No test changes, as the functionality isn't actually affected.