Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input configuration implementation #3407

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Fix input configuration implementation #3407

merged 5 commits into from
Jun 5, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

Some of this code was written with an incorrect understanding (that multiple click and scroll modes could be active at once).

That required an API change.

Also some improved logging and tidying up.

No test changes, as the functionality isn't actually affected.

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner May 31, 2024 11:51
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 47.13376% with 83 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (bc301b6) to head (0613d64).
Report is 438 commits behind head on main.

Files with missing lines Patch % Lines
...demo_server/server_example_input_device_config.cpp 42.85% 44 Missing ⚠️
src/platforms/evdev/libinput_device.cpp 48.43% 33 Missing ⚠️
src/common/input/mir_touchpad_config.cpp 55.55% 4 Missing ⚠️
...r_demo_server/server_example_input_device_config.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3407      +/-   ##
==========================================
- Coverage   77.31%   77.27%   -0.05%     
==========================================
  Files        1075     1075              
  Lines       68345    68401      +56     
==========================================
+ Hits        52841    52854      +13     
- Misses      15504    15547      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanGriffiths AlanGriffiths force-pushed the evdev-input-cleanup branch from 18705e6 to 806884a Compare May 31, 2024 15:37
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but overall looks good

@AlanGriffiths AlanGriffiths force-pushed the evdev-input-cleanup branch from a12b785 to 4f23c1d Compare June 4, 2024 22:08
@AlanGriffiths AlanGriffiths force-pushed the evdev-input-cleanup branch from 4f23c1d to 0613d64 Compare June 5, 2024 09:47
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mattkae mattkae added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit fdeafdf Jun 5, 2024
35 of 37 checks passed
@mattkae mattkae deleted the evdev-input-cleanup branch June 5, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants