Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#3259) buffer size should be the possibly-inverted extents size so that the final image is correct #3292

Merged
merged 1 commit into from
Mar 19, 2024
Merged

(#3259) buffer size should be the possibly-inverted extents size so that the final image is correct #3292

merged 1 commit into from
Mar 19, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Mar 18, 2024

fixes #3259

Screenshots

Left

20240318_15h54m23s_grim

Right

20240318_15h54m44s_grim

Inverted (Scaled)

20240318_15h55m27s_grim

Normal

20240318_15h56m07s_grim

@mattkae mattkae requested a review from Saviq March 18, 2024 19:58
@mattkae mattkae requested a review from a team as a code owner March 18, 2024 19:58
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.41%. Comparing base (a3aca60) to head (f8f2588).
Report is 5 commits behind head on main.

Files Patch % Lines
src/server/frontend_wayland/wlr_screencopy_v1.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
- Coverage   77.41%   77.41%   -0.01%     
==========================================
  Files        1074     1064      -10     
  Lines       68448    68062     -386     
==========================================
- Hits        52988    52687     -301     
+ Misses      15460    15375      -85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlanGriffiths
AlanGriffiths approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but could you also look at the next function in the same file? That also appears to conflate the output mode size with the configured extents.

@mattkae
Copy link
Contributor Author

mattkae commented Mar 19, 2024

This looks reasonable, but could you also look at the next function in the same file? That also appears to conflate the output mode size with the configured extents.

I have fixed this now too. Re-requesting you 👍

@mattkae mattkae requested a review from AlanGriffiths March 19, 2024 13:25
AlanGriffiths
AlanGriffiths approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit afeb8da Mar 19, 2024
34 of 36 checks passed
@AlanGriffiths AlanGriffiths deleted the bugfix/3259 branch March 19, 2024 17:06
mattkae pushed a commit that referenced this pull request Mar 27, 2024
@AlanGriffiths @mattkae
(#3259) buffer size should be the possibly-inverted extents size so t…
797b61a 
…hat the final image is correct (#3292)

fixes #3259

# Screenshots
## Left

![20240318_15h54m23s_grim](https://github.com/canonical/mir/assets/25062299/7815dfb9-ed03-491f-8422-e417d5d39d3b)

## Right

![20240318_15h54m44s_grim](https://github.com/canonical/mir/assets/25062299/412bd5a8-4935-4c4f-8c9a-6c710bf232b4)

## Inverted (Scaled)

![20240318_15h55m27s_grim](https://github.com/canonical/mir/assets/25062299/4bd4a102-c666-431f-86f8-ec005d3c457a)

## Normal

![20240318_15h56m07s_grim](https://github.com/canonical/mir/assets/25062299/f50be354-d664-4589-a75a-63e818d8597f)
mattkae pushed a commit that referenced this pull request Mar 27, 2024
@AlanGriffiths @mattkae
(#3259) buffer size should be the possibly-inverted extents size so t…
918fd5e 
…hat the final image is correct (#3292)

fixes #3259

# Screenshots
## Left

![20240318_15h54m23s_grim](https://github.com/canonical/mir/assets/25062299/7815dfb9-ed03-491f-8422-e417d5d39d3b)

## Right

![20240318_15h54m44s_grim](https://github.com/canonical/mir/assets/25062299/412bd5a8-4935-4c4f-8c9a-6c710bf232b4)

## Inverted (Scaled)

![20240318_15h55m27s_grim](https://github.com/canonical/mir/assets/25062299/4bd4a102-c666-431f-86f8-ec005d3c457a)

## Normal

![20240318_15h56m07s_grim](https://github.com/canonical/mir/assets/25062299/f50be354-d664-4589-a75a-63e818d8597f)
mattkae pushed a commit that referenced this pull request Mar 27, 2024
@AlanGriffiths @mattkae
(#3259) buffer size should be the possibly-inverted extents size so t…
41e36f3 
…hat the final image is correct (#3292)

fixes #3259

# Screenshots
## Left

![20240318_15h54m23s_grim](https://github.com/canonical/mir/assets/25062299/7815dfb9-ed03-491f-8422-e417d5d39d3b)

## Right

![20240318_15h54m44s_grim](https://github.com/canonical/mir/assets/25062299/412bd5a8-4935-4c4f-8c9a-6c710bf232b4)

## Inverted (Scaled)

![20240318_15h55m27s_grim](https://github.com/canonical/mir/assets/25062299/4bd4a102-c666-431f-86f8-ec005d3c457a)

## Normal

![20240318_15h56m07s_grim](https://github.com/canonical/mir/assets/25062299/f50be354-d664-4589-a75a-63e818d8597f)
mattkae pushed a commit that referenced this pull request Mar 27, 2024
@AlanGriffiths @mattkae
(#3259) buffer size should be the possibly-inverted extents size so t…
2959dac 
…hat the final image is correct (#3292)

fixes #3259

# Screenshots
## Left

![20240318_15h54m23s_grim](https://github.com/canonical/mir/assets/25062299/7815dfb9-ed03-491f-8422-e417d5d39d3b)

## Right

![20240318_15h54m44s_grim](https://github.com/canonical/mir/assets/25062299/412bd5a8-4935-4c4f-8c9a-6c710bf232b4)

## Inverted (Scaled)

![20240318_15h55m27s_grim](https://github.com/canonical/mir/assets/25062299/4bd4a102-c666-431f-86f8-ec005d3c457a)

## Normal

![20240318_15h56m07s_grim](https://github.com/canonical/mir/assets/25062299/f50be354-d664-4589-a75a-63e818d8597f)
mattkae pushed a commit that referenced this pull request Mar 28, 2024
@AlanGriffiths @mattkae
(#3259) buffer size should be the possibly-inverted extents size so t…
20ffd3e 
…hat the final image is correct (#3292)

fixes #3259

# Screenshots
## Left

![20240318_15h54m23s_grim](https://github.com/canonical/mir/assets/25062299/7815dfb9-ed03-491f-8422-e417d5d39d3b)

## Right

![20240318_15h54m44s_grim](https://github.com/canonical/mir/assets/25062299/412bd5a8-4935-4c4f-8c9a-6c710bf232b4)

## Inverted (Scaled)

![20240318_15h55m27s_grim](https://github.com/canonical/mir/assets/25062299/4bd4a102-c666-431f-86f8-ec005d3c457a)

## Normal

![20240318_15h56m07s_grim](https://github.com/canonical/mir/assets/25062299/f50be354-d664-4589-a75a-63e818d8597f)
AlanGriffiths added a commit that referenced this pull request Apr 3, 2024
@AlanGriffiths
(#3259) buffer size should be the possibly-inverted extents size so t…
6a7c962 
…hat the final image is correct (#3292)

fixes #3259

# Screenshots
## Left

![20240318_15h54m23s_grim](https://github.com/canonical/mir/assets/25062299/7815dfb9-ed03-491f-8422-e417d5d39d3b)

## Right

![20240318_15h54m44s_grim](https://github.com/canonical/mir/assets/25062299/412bd5a8-4935-4c4f-8c9a-6c710bf232b4)

## Inverted (Scaled)

![20240318_15h55m27s_grim](https://github.com/canonical/mir/assets/25062299/4bd4a102-c666-431f-86f8-ec005d3c457a)

## Normal

![20240318_15h56m07s_grim](https://github.com/canonical/mir/assets/25062299/f50be354-d664-4589-a75a-63e818d8597f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@Saviq Saviq Awaiting requested review from Saviq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screenshots wrong when display rotated
2 participants
@mattkae @AlanGriffiths