Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Merge pull request #3216 from MirServer/feature/alt-t… #3234

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Feb 15, 2024

…ick-improved""

This reverts commit 74d847e.

@mattkae mattkae requested a review from Saviq February 15, 2024 14:54
@mattkae mattkae requested a review from a team as a code owner February 15, 2024 14:54
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (0d476e2) 77.72% compared to head (2a35d7b) 77.74%.

Files Patch % Lines
src/miral/application_selector.cpp 74.28% 18 Missing ⚠️
src/miral/window_management_trace.cpp 0.00% 6 Missing ⚠️
src/miral/minimal_window_manager.cpp 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
+ Coverage   77.72%   77.74%   +0.02%     
==========================================
  Files        1072     1072              
  Lines       67433    67507      +74     
==========================================
+ Hits        52411    52484      +73     
- Misses      15022    15023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, Fix is in Frame

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Feb 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 15, 2024
Revert "Revert "Merge pull request #3216 from MirServer/feature/alt-t…
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2024
@mattkae mattkae added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 91fddda Feb 15, 2024
33 of 35 checks passed
@mattkae mattkae deleted the bugfix/alt-tab branch February 15, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants