Sequence xdg-top-level and xdg-surface configure events correctly. #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wmww I'm not convinced this is the best way fix this, do you have any thoughts on an alternative? |
wmww
approved these changes
Mar 24, 2018
| {} | ||
| { | ||
| // TODO Make this readable!!! This "works" by exploiting the non-obvious side-effect | ||
| // of causing a zxdg_surface_v6_send_configure() event to become pending. |
There was a problem hiding this comment.
Thanks for adding this comment
|
|
||
| void mir::frontend::XdgSurfaceV6::set_next_commit_action(std::function<void()> action) | ||
| { | ||
| next_commit_action = [this, action] |
There was a problem hiding this comment.
[non-blocking] perhaps next_commit_action could be a vector so multiple lambdas can be added and executed with no danger of overwriting and not running an action.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qtwayland gets confused by receiving these event out of order. (Fixes #280)