Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll to top of form when non-field errors are present MAASENG-3515 #5503

Merged
merged 2 commits into from
Jul 18, 2024
Merged

feat: scroll to top of form when non-field errors are present MAASENG-3515 #5503

merged 2 commits into from
Jul 18, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jul 18, 2024 •
edited by jira bot
Loading

Done

  • When a non-field (i.e. backend) error is received after submitting a form, the error message will now automatically be scrolled into view

QA steps

  • Go to machine list
  • Open "Add machine" form
  • Zoom in (or shrink window) until the MAC address field is off-screen
  • Scroll down and enter a MAC address that's already in use on your MAAS instance
  • Fill out the other mandatory fields and submit the form
  • Ensure that the error message from the backend is scrolled into view

Fixes

Fixes MAASENG-3515

@ndv99 ndv99 requested a review from tmerten July 18, 2024 10:18
@webteam-app
Copy link

Demo

Jenkins

demos.haus

tmerten
tmerten approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
And thanks for the additional comments in setupTest

@ndv99 ndv99 merged commit 90df80f into canonical:main Jul 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmerten tmerten tmerten approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @tmerten