Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add msw library for mocking API requests #5492

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jun 26, 2024

Done

  • test: add msw library for mocking API requests

QA steps

  • [ ]

Fixes

Fixes: https://warthogs.atlassian.net/browse/MAASENG-3402

Screenshots

Notes

@webteam-app
Copy link

@petermakowski petermakowski requested a review from ndv99 June 26, 2024 12:37
@petermakowski petermakowski force-pushed the setup-msw-MAASENG-3402 branch 2 times, most recently from 1bfdbcf to f1d8f3d Compare June 26, 2024 12:42
@petermakowski petermakowski marked this pull request as ready for review June 26, 2024 12:42
@ndv99
Copy link
Contributor

ndv99 commented Jun 26, 2024

Some tests are still failing on this, although code appears good for the most part.

@petermakowski petermakowski force-pushed the setup-msw-MAASENG-3402 branch 4 times, most recently from ea412e7 to f37ee3d Compare June 27, 2024 10:44
Signed-off-by: Peter Makowski <peter.makowski@canonical.com>
@petermakowski petermakowski force-pushed the setup-msw-MAASENG-3402 branch from f37ee3d to 39d1909 Compare June 27, 2024 10:45
@petermakowski
Copy link
Contributor Author

Some tests are still failing on this, although code appears good for the most part.

@ndv99 These are passing now!

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@petermakowski petermakowski merged commit 2c64499 into canonical:main Jun 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants