fix: limit WebSocket message backlog on reconnection #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Signed-off-by: Peter Makowski <peter.makowski@canonical.com>
petermakowski
force-pushed
the
fix-reconnect-ui-high-cpu-lp#2070304
branch
from
95b23d5 to
f1368e9
Compare
petermakowski
changed the title
ndv99
added
Review: Core needed
ndv99
approved these changes
Jun 26, 2024
r00ta
approved these changes
Jun 26, 2024
ndv99
added
Review: Core +1
petermakowski
added a commit
to petermakowski/maas-ui
that referenced
this pull request
Jun 26, 2024
- Update WebSocket reconnection logic to prevent overwhelming the server with a flood of queued messages when the connection is re-established. Signed-off-by: Peter Makowski <peter.makowski@canonical.com>
petermakowski
added a commit
to petermakowski/maas-ui
that referenced
this pull request
Jun 26, 2024
- Update WebSocket reconnection logic to prevent overwhelming the server with a flood of queued messages when the connection is re-established.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA steps
Fixes
Fixes: https://bugs.launchpad.net/maas/+bug/2070304
https://warthogs.atlassian.net/browse/MAASENG-3433
Screenshots
N/A
Notes
This change introduces a
maxEnqueuedMessageslimit to prevent overwhelming the server with a backlog of messages upon WebSocket reconnection. The limit is set to 30, which accommodates the typical 5-25 messages generated on page load plus some buffer for additional user actions.