fix: html error formatting MAASENG-2935 #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Jay-Topher
reviewed
Apr 15, 2024
Co-authored-by: Jones Ogolo <47540149+Jay-Topher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
In some rare scenarios HTML content might be returned as a response. This change makes sure that we display text only and not entire raw HTML string.
QA steps
HTML formatting is hard QA without simulating an actual nginx error and also already covered by tests. Focus on verifying that other errors are displayed as before.
Fixes
Fixes: MAASENG-2935
Screenshots
Before
After
Notes