Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devices): use MainToolbar in DeviceListHeader MAASENG-2515 #5254

Merged

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jan 5, 2024

Done

  • Bumped maas-react-components to v1.15.0
  • Replaced SectionHeader with MainToolbar in DeviceListHeader
  • Move searchbox and filter into header
  • Moved DeviceFilterAccordion folder under DeviceListHeader
  • Deleted DeviceListControls
  • Moved DeviceListControls test to DeviceListHeader

QA steps

  • Go to /devices
  • Ensure the header renders correctly across all breakpoints
  • Ensure the filters, searchbox, and buttons work correctly

Fixes

Fixes MAASENG-2515

Screenshots

Before

image

After

image

Notes

I am aware of the (lack of) padding issue at the top of the screen. The same is true on the controller list, and this will be fixed when pages are all using ContentSection. However, this collection of tasks needs to be done first.

@webteam-app
Copy link

Demo starting at https://maas-ui-5254.demos.haus

@Jay-Topher
Copy link
Contributor

Is there no way we can add a padding with a #TODO tag to take it of once said implementation is done? other than that, everything looks good to me.

@ndv99
Copy link
Contributor Author

ndv99 commented Jan 5, 2024

Is there no way we can add a padding with a #TODO tag to take it of once said implementation is done? other than that, everything looks good to me.

I suppose we could yeah, might just do this as a global style on MainToolbar with a TODO comment.

Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better, thanks

@ndv99 ndv99 merged commit 0701d50 into canonical:main Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants