VM: Rework firmware detection (from Incus) #14032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
force-pushed
the
tp-vm-firmwares
branch
8 times, most recently
from
619dbea
to
0607828
Compare
tomponline
changed the title
Signed-off-by: Dustin Sweigart <dustins@swigg.net> (cherry picked from commit 6d04eb437b0f35ba0faca3e25b846cdbccf5d8ce) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
Quite a few environments use OVMF on arm64 rather than the more technicaly correct AAVMF name. Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit cc33d436d193f12a38818482c050fafd1ecae04c) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 5b093d06795e2c65cf5b4682b341237c1acd31d3) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 9072c73f9269113cc5ff46fd3014f6a291c59e54) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 8e33c788fa48ffceaf5a4f91eeb9835141dd7862) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
tomponline
force-pushed
the
tp-vm-firmwares
branch
2 times, most recently
from
16d0938
to
5a85fb6
Compare
tomponline
changed the title
tomponline
force-pushed
the
tp-vm-firmwares
branch
6 times, most recently
from
15e99db
to
8a086f4
Compare
tomponline
force-pushed
the
tp-vm-firmwares
branch
from
8a086f4
to
87805f8
Compare
Signed-off-by: dkwo <nicolopiazzalunga@gmail.com> (cherry picked from commit cfbbe5d289ac5285b2a9880bd6f6cbb9041f8a4f) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
…d LXD_OVMF_PATH Supporting multiple search paths. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Modified to support boot.debug_edk2 Signed-off-by: Dustin Sweigart <dustins@swigg.net> (cherry picked from commit 2546c56300c08aabb68278a483a0dfa696f99f61) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
…heckFeatures Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…t during generateQemuConfigFile Allows access to start time firmware path for apparmor profile generation. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…are path Rather than allowing access to all potential firmware directories. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…s function Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
force-pushed
the
tp-vm-firmwares
branch
from
87805f8
to
7bdeb9b
Compare
mihalicyn
approved these changes
Sep 4, 2024
tomponline
added a commit
that referenced
this pull request
Sep 6, 2024
Based on: - lxc/incus#1187 - lxc/incus#1193 Follows on from #14032 Also improves the removal of old firmware vars files by not checking the if the associated firmwares exist on the host and not trying to remove the same files multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
Plus adds support for Ubuntu 24.04 OVMF and seabios firmware locations, and maintains support for both
LXD_QEMU_FW_PATHandLXD_OVMF_PATHenvironmental variables (accepting multiple search paths).Also changes how apparmor profile is generated to only allow access to specific firmware file selected.
Tested with: