Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc: Add support for creating profile from yaml (from Incus) #13849

Merged

Conversation

gabrielmougard
Copy link
Contributor

cherry-picked from: lxc/incus#756

@tomponline tomponline changed the title lxc/profile: Add support for creating profile from yaml lxc: Add support for creating profile from yaml (from Incus) Aug 2, 2024
@tomponline
Copy link
Member

@gabrielmougard added "(from Incus)" to PR description to help with attribution, please can you do this for future PRs. Ta

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add tests for this functionality.

lxc/profile.go Outdated Show resolved Hide resolved
awalvie and others added 2 commits August 2, 2024 16:46
Part of canonical#741

Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com>
(cherry picked from commit 7c84b4b60b864f722ac373db9f1ad3280edb9bd2)
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
License: Apache-2.0
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
@gabrielmougard gabrielmougard force-pushed the incus-pr/profile-from-yaml branch 7 times, most recently from 7042c35 to c98415c Compare August 2, 2024 17:23
test/suites/basic.sh Outdated Show resolved Hide resolved
test/suites/basic.sh Outdated Show resolved Hide resolved
test/suites/basic.sh Outdated Show resolved Hide resolved
test/suites/basic.sh Outdated Show resolved Hide resolved
test/suites/basic.sh Outdated Show resolved Hide resolved
test/suites/basic.sh Outdated Show resolved Hide resolved
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
@tomponline tomponline merged commit c795f4d into canonical:main Aug 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants