Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust ca certs #12513

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Trust ca certs #12513

merged 3 commits into from
Nov 15, 2023

Commits on Nov 6, 2023

  1. incusd/auth: Fix handling of trusted certs in CA mode

    Closes canonical#218
    
    Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    Signed-off-by: Mark Laing <mark.laing@canonical.com>
    stgraber authored and markylaing committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5cdc9a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. tests: Properly test core.trust_ca_certificates

    The test as it was written was quite incorrect.
    
    core.trust_ca_certificates causes valid certificates to be implictly
    trusted and not get a certificate store entry.
    
    But as the test was run immediately after a configuration where
    core.trust_ca_certificates was not set, there was a leftover entry in
    the trust store which the test was then checking.
    
    This corrects the test by clearing the trust store after the initial
    test and by further making sure that when using
    core.trust_ca_certificates, no trust store entries get created.
    
    Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
    Signed-off-by: Mark Laing <mark.laing@canonical.com>
    stgraber authored and markylaing committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    64fa9a5 View commit details
    Browse the repository at this point in the history
  2. lxd: Enforce users to be authenticated before running the access hand…

    …ler.
    
    Previously we ran the access handler regardless of whether a request was
    authenticated. This would usually fail because there would be no
    username in the request context. However we need to be careful that a
    user is authenticated if predicating access on the presence of a CA
    certificate.
    
    Signed-off-by: Mark Laing <mark.laing@canonical.com>
    markylaing committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7cce0df View commit details
    Browse the repository at this point in the history