Add testing for OVN uplink attached to VLAN #302
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
simondeziel
reviewed
Oct 3, 2024
| ovn-nbctl --bare --format=csv --columns=type,tag find logical_switch_port | grep -F "localnet,10" | ||
|
|
||
| echo "==> Ensure OVS configured to accept VLAN traffic" | ||
| uplink_port=$(ovs-vsctl show | grep "Bridge lxdovn" | awk '{print $2"b"}') |
There was a problem hiding this comment.
grep's not strictly needed as awk can do string matching too:
Suggested change
| uplink_port=$(ovs-vsctl show | grep "Bridge lxdovn" | awk '{print $2"b"}') | |
| uplink_port=$(ovs-vsctl show | awk '/Bridge lxdovn/ {print $2"b"}') |
|
|
||
| lxc config device set c1-lxdbr0 eth0 vlan=10 | ||
| lxc exec c1-lxdbr0 -- ip addr add 10.10.10.100/24 dev eth0 | ||
| lxc exec c1-lxdbr0 -- ip link set dev eth0 up |
There was a problem hiding this comment.
In my tests, the device remains up even after adding the vlan=10 config so this should not be needed.
|
|
||
| lxc exec c1-ovn -- ping -nc1 -4 -w5 10.10.10.100 | ||
|
|
||
| lxc rm -f c1-lxdbr0 c1-ovn |
There was a problem hiding this comment.
Suggested change
| lxc rm -f c1-lxdbr0 c1-ovn | |
| lxc delete -f c1-lxdbr0 c1-ovn |
We try not to use command aliases.
| lxc exec c1-lxdbr0 -- ip route add default via 10.10.10.1 | ||
| sleep 5 | ||
|
|
||
| lxc exec c1-ovn -- ping -nc1 -4 -w5 10.10.10.100 |
There was a problem hiding this comment.
I'd like to see a ping from c1-lxdbr0 to c1-ovn. This will likely require getting c1-ovn's IP with lxc list -c 4 -f csv c1-ovn | cut -d " " -f1 (or similar) as DNS won't work.
| @@ -2096,6 +2096,51 @@ ovn_leases_tests() { | |||
| lxc network delete lxdbr0 | |||
| } | |||
|
|
|||
| ovn_vlan_uplink_tests() { | |||
There was a problem hiding this comment.
This test will need to be called (at the bottom of the script) if the right API extension is detected. See hasNeededAPIExtension in bin/helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing for when an OVN uplink network is attached to a VLAN.
Setting as draft until this feature is in latest edge.