Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite event handlers to only run data migration on database created event #24

Merged
merged 3 commits into from
Jan 5, 2023
Merged

rewrite event handlers to only run data migration on database created event #24

merged 3 commits into from
Jan 5, 2023

Conversation

agathanatasha
Copy link
Contributor

Only run database migration on database created event
Updated unit tests

@agathanatasha agathanatasha requested a review from a team as a code owner January 4, 2023 23:10
@agathanatasha agathanatasha mentioned this pull request Jan 4, 2023
Closed
nsklikas
nsklikas reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the tests. Left a couple of minor comments, but overall LGTM.

tests/unit/test_charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
@agathanatasha agathanatasha requested a review from nsklikas January 5, 2023 15:54
@agathanatasha agathanatasha force-pushed the IAM-36-db-migration-rewrite branch from 0ffa993 to 1e4eb48 Compare January 5, 2023 16:01
natalian98
natalian98 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@natalian98 natalian98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@agathanatasha agathanatasha merged commit 21831b2 into main Jan 5, 2023
@agathanatasha agathanatasha deleted the IAM-36-db-migration-rewrite branch January 5, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalian98 natalian98 natalian98 approved these changes

@nsklikas nsklikas nsklikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agathanatasha @nsklikas @natalian98