Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress #22

Merged
merged 9 commits into from
Jan 5, 2023
Merged

Add ingress #22

merged 9 commits into from
Jan 5, 2023

Conversation

nsklikas
Copy link
Contributor

Add ingress relation.

To test this on a model that has kratos deployed you need to run (we need channel=latest/edge due to canonical/traefik-k8s-operator#114):

juju deploy traefik-k8s traefik-public --channel latest/edge
juju deploy traefik-k8s traefik-admin --channel latest/edge
juju config traefik-public external_hostname=some_host
juju config traefik-admin external_hostname=some_host
juju relate traefik-public kratos:public-ingress
juju relate traefik-admin kratos:admin-ingress

After all models in the unit reach an active state, get the traefik IPs by running:

juju status
...
traefik-admin/0*                  active       idle   {admin_IP}         
traefik-public/0*                  active       idle   {public_IP}         

Then on your browser you should be able to reach Kratos APIs through these IPs (eg http://{admin_IP}/{juju_model_name}-kratos/admin/identities and http://{public_IP}/{juju_model_name}-kratos/.well-known/ory/webauthn.js).

Currently there is a problem with the traefik charm and all traffic will be redirected to the Kratos leader.

@nsklikas nsklikas requested a review from gruyaume December 14, 2022 13:59
@nsklikas nsklikas requested a review from a team as a code owner December 14, 2022 13:59
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@natalian98
Copy link
Contributor

Would it be possible to add some integration test for this relation and/or update the readme?
I also see that the traefik fix was merged (rev98), maybe we could add a note about minimal revision?

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@agathanatasha agathanatasha self-requested a review January 3, 2023 23:04
agathanatasha
agathanatasha previously approved these changes Jan 3, 2023
gruyaume
gruyaume previously approved these changes Jan 4, 2023
@nsklikas nsklikas dismissed stale reviews from gruyaume and agathanatasha via c5ab1e3 January 5, 2023 11:30
@nsklikas nsklikas requested a review from a team January 5, 2023 11:45
natalian98
natalian98 previously approved these changes Jan 5, 2023
@nsklikas nsklikas requested a review from a team January 5, 2023 11:48
@nsklikas nsklikas merged commit bf1bde4 into main Jan 5, 2023
@nsklikas nsklikas deleted the IAM-151-ingress branch January 5, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants