fix: wait-for units instead of applications #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NohaIhab
approved these changes
Jan 24, 2025
NohaIhab
pushed a commit
that referenced
this pull request
Jan 27, 2025
NohaIhab
added a commit
that referenced
this pull request
Jan 29, 2025
* init: pass cached charms to v1 bundle tests * add build dependency for bundle tests * add step to download packed charms * fix: wait-for units instead of applications (#659) * remove no_build option and refactor v1 tests * update v2 bundle tests * implement helper function to update context + comments * fix: update logs action (#663) Ref canonical/kubeflow-ci#152 * fix: modify ci.yaml release job to need get-charm-paths-channel * update tests README --------- Co-authored-by: Orfeas Kourkakis <orfeas.kourkakis@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait-forunits instead of applications due to juju/juju#18625.