Make k8s get-join-token $hostname optional
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiseschmidtgen
approved these changes
May 31, 2024
neoaggelos
added a commit
that referenced
this pull request
Jun 3, 2024
* Use separate table in database for worker tokens * allow worker tokens with empty name to always match * make k8s get-join-token hostname optional
bschimke95
added a commit
that referenced
this pull request
Jun 3, 2024
* Use separate table in database for worker tokens * allow worker tokens with empty name to always match * make k8s get-join-token hostname optional Co-authored-by: Benjamin Schimke <benjamin.schimke@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
k8s get-join-tokento return tokens without specifying a hostname (and match any name specified duringk8s join-cluster)Changes
worker_tokensdatabase tabledatabase.CheckWorkerNodeToken()checks against the token itself, not the node name