Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy control-plane taint from bootstrap config #425

Merged
merged 4 commits into from
May 22, 2024
Merged

Copy control-plane taint from bootstrap config #425

merged 4 commits into from
May 22, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented May 16, 2024

Complete the register control-planes with taints task and test that taints are adequately applied on bootstrap

@addyess addyess added the bug Something isn't working label May 16, 2024
@addyess addyess requested a review from a team as a code owner May 16, 2024 14:38
bschimke95
bschimke95 reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, two comments

src/k8s/pkg/k8sd/types/cluster_config_convert.go Outdated Show resolved Hide resolved
tests/integration/tests/test_control_plane_taints.py Outdated Show resolved Hide resolved
@addyess addyess force-pushed the akd/copy-bootstrap-taints-to-kubelet-taints branch from c0dff91 to a577d93 Compare May 16, 2024 16:08
@addyess addyess force-pushed the akd/copy-bootstrap-taints-to-kubelet-taints branch from a577d93 to 04dfccb Compare May 16, 2024 16:09
@addyess addyess force-pushed the akd/copy-bootstrap-taints-to-kubelet-taints branch from 227d5ac to 0b026c9 Compare May 16, 2024 16:17
@github-actions GitHub Actions
Copy link
Contributor

Package Line Rate
github.com/canonical/k8s/api/v1 35%
github.com/canonical/k8s/cmd/k8s-apiserver-proxy 0%
github.com/canonical/k8s/cmd/k8s 37%
github.com/canonical/k8s/cmd/k8sd 0%
github.com/canonical/k8s/cmd 0%
github.com/canonical/k8s/cmd/util 15%
github.com/canonical/k8s/pkg/client/dqlite 48%
github.com/canonical/k8s/pkg/client/helm 5%
github.com/canonical/k8s/pkg/client/helm/mock 100%
github.com/canonical/k8s/pkg/client/kubernetes 69%
github.com/canonical/k8s/pkg/k8s/client 0%
github.com/canonical/k8s/pkg/k8s/client/mock 8%
github.com/canonical/k8s/pkg/k8sd/api 14%
github.com/canonical/k8s/pkg/k8sd/api/impl 0%
github.com/canonical/k8s/pkg/k8sd/app 11%
github.com/canonical/k8s/pkg/k8sd/controllers 45%
github.com/canonical/k8s/pkg/k8sd/database 48%
github.com/canonical/k8s/pkg/k8sd/database/util 0%
github.com/canonical/k8s/pkg/k8sd/features/cilium 0%
github.com/canonical/k8s/pkg/k8sd/features/coredns 0%
github.com/canonical/k8s/pkg/k8sd/features 0%
github.com/canonical/k8s/pkg/k8sd/features/localpv 0%
github.com/canonical/k8s/pkg/k8sd/features/metrics-server 100%
github.com/canonical/k8s/pkg/k8sd/pki 52%
github.com/canonical/k8s/pkg/k8sd/setup 77%
github.com/canonical/k8s/pkg/k8sd/types 78%
github.com/canonical/k8s/pkg/proxy 6%
github.com/canonical/k8s/pkg/snap/mock 85%
github.com/canonical/k8s/pkg/snap 17%
github.com/canonical/k8s/pkg/snap/util 90%
github.com/canonical/k8s/pkg/utils 60%
github.com/canonical/k8s/pkg/utils/control 100%
github.com/canonical/k8s/pkg/utils/errors 100%
github.com/canonical/k8s/pkg/utils/experimental/snapdconfig 12%
github.com/canonical/k8s/pkg/utils/node 0%
github.com/canonical/k8s/pkg/utils/shims 0%
Summary 37% (2553 / 6902)

@addyess addyess requested a review from bschimke95 May 17, 2024 09:46
bschimke95
bschimke95 approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/integration/tests/test_control_plane_taints.py Show resolved Hide resolved
@addyess addyess merged commit f4fd0e3 into main May 22, 2024
13 checks passed
@addyess addyess deleted the akd/copy-bootstrap-taints-to-kubelet-taints branch May 22, 2024 21:33
addyess added a commit that referenced this pull request May 22, 2024
@addyess
Copy control-plane taint from bootstrap config (#425)
872cfc4 
* Copy control-plane taint from bootstrap config
* Add tests for ControlPlaneTaints
* Empty control plane taints slices can be ignored
addyess added a commit that referenced this pull request May 23, 2024
@addyess
Copy control-plane taint from bootstrap config (#425) (#441)
28f316e 
* Copy control-plane taint from bootstrap config
* Add tests for ControlPlaneTaints
* Empty control plane taints slices can be ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @bschimke95