Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify integration tests #116

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jul 4, 2024

This PR aims at reducing the boilerplate for tests and benchmarks. In that direction it:

  • aligns the names of the utility function (now consistently called {create,update,delete}Key)
  • tries to use them everywhere possible
  • aligns the usage of gomega for the admission test
  • removes unused helper functions

From a functionality level, it also removes same-nesting inter-test dependencies which might break the tests if the run filters them (very present in the list tests). This has also a nice effect of reducing a bit indentation.

@marco6 marco6 requested a review from a team as a code owner July 4, 2024 08:12
@marco6 marco6 requested a review from bschimke95 July 4, 2024 08:12
@marco6 marco6 mentioned this pull request Jul 4, 2024
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor nits

test/list_test.go Outdated Show resolved Hide resolved
test/list_test.go Outdated Show resolved Hide resolved
test/list_test.go Outdated Show resolved Hide resolved
test/list_test.go Outdated Show resolved Hide resolved
test/list_test.go Outdated Show resolved Hide resolved
test/update_test.go Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6 marco6 merged commit 1fc0646 into canonical:master Jul 5, 2024
8 of 9 checks passed
@marco6 marco6 deleted the simplify-tests branch July 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants