Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UpdateSameKeyLinearity #115

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jul 3, 2024

This test is too imprecise to be useful and making it precise is unpractical. Right now if the second batch takes twice the time (leading to an exponential growth) the test still pass.

It is also the test that takes the longest amount of time in the whole pipeline.

This test is too imprecise to be useful and making it precise is
unpractical. It is also the test that takes the longest amount of time
in the whole pipeline.
@marco6 marco6 requested a review from a team as a code owner July 3, 2024 09:32
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6 marco6 merged commit 3e93d6a into canonical:master Jul 3, 2024
8 of 9 checks passed
@marco6 marco6 deleted the remove-timed-tests branch July 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants