Juju 7464/reuse dial logic #1529
Conversation
internal/ssh/dial.go
Outdated
| } | ||
| } | ||
| if client == nil { | ||
| return nil, fmt.Errorf("failed to dial controller ssh server: %v", errors) |
There was a problem hiding this comment.
this PR seems to change how we return errors.. is this an agreed direction?
There was a problem hiding this comment.
this is just the way to return errors in ssh dial, no change to the controller's dial
There was a problem hiding this comment.
well, no, it's about how we return and log errors.. i would suggest returning always returning a sensible error.. now, how the ssh server's handler treats, logs and returns these errors to its client is a different matter
There was a problem hiding this comment.
ah ok, i've changed it to use the errorrs pkg with the msg decoupled from the error.
internal/ssh/dial.go
Outdated
| } | ||
| } | ||
| if client == nil { | ||
| return nil, fmt.Errorf("failed to dial controller ssh server: %v", errors) |
There was a problem hiding this comment.
well, no, it's about how we return and log errors.. i would suggest returning always returning a sensible error.. now, how the ssh server's handler treats, logs and returns these errors to its client is a different matter
SimoneDutto
force-pushed
the
JUJU-7464/reuse-dial-logic
branch
from
36d2ee1 to
3018233
Compare
Description
In this PR we reuse some logic from the rpc dial pkg to get addresses from Controller.
First commit is just extracting the GetAddressesAndTLSConfig from the Dial method and add some tests for it.
Engineering checklist
Test instructions