implement limit connections #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
reviewed
Jan 20, 2025
kian99
approved these changes
Jan 21, 2025
SimoneDutto
force-pushed
the
implement-limit-connections
branch
from
370a931 to
f845686
Compare
SimoneDutto
force-pushed
the
implement-limit-connections
branch
from
f845686 to
547dc90
Compare
alesstimec
reviewed
Jan 21, 2025
alesstimec
requested changes
Jan 21, 2025
alesstimec
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an implementation of the MaxConcurrentRequest for the ssh server.
The implementation is a copy/paste of https://cs.opensource.google/go/x/net/+/refs/tags/v0.34.0:netutil/listen.go with an additional timeout.
In fact the LimitListener hangs forever the
Accept()until a seat is made available, making it hard to test and also counter intuitive, because we want to close connection when we reach the limit.The error from the SSH client is:
Note
This is the first simple implementation until we get a better way of doing it by interacting with the gliderlab/ssh server. I am working on a issue + pr to make it possible.
Engineering checklist
Test instructions