fix(internal/jimm/controller.go): add default cloud region if none exist #1513
+114
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
requested review from
SimoneDutto and
kian99
and removed request for
SimoneDutto and
kian99
kian99
approved these changes
Jan 9, 2025
alesstimec
force-pushed
the
add-controller-with-cloud-with-no-regions
branch
from
a46fb50 to
081cb58
Compare
SimoneDutto
approved these changes
Jan 9, 2025
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2024 Canonical. | |||
| // Copyright 2025 Canonical. | |||
There was a problem hiding this comment.
this is happening to me as well, do we want to change the cr header when we touch a file?
When adding a controller JIMM will query the controller for all known clouds and then add those clouds to its internal DB. If a cloud (e.g. MAAS or k8s) has no regions, JIMM would be unable to add a model to that cloud as it does not store association between clouds and controllers. To solve the issue we add a `default` region to clouds that do not have any regions and that cloud region will only have one controller associated with it.
alesstimec
force-pushed
the
add-controller-with-cloud-with-no-regions
branch
from
081cb58 to
9fd582d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a controller JIMM will query the controller for all known clouds and then add those clouds to its internal DB. If a cloud (e.g. MAAS or k8s) has no regions, JIMM would be unable to add a model to that cloud as it does not store association between clouds and controllers. To solve the issue we add a
defaultregion to clouds that do not have any regions and that cloud region will only have one controller associated with it.Description
Engineering checklist
Test instructions