Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add external access docs #154

Merged
merged 5 commits into from
May 3, 2024
Merged

add external access docs #154

merged 5 commits into from
May 3, 2024

Conversation

Thanhphan1147
Copy link
Collaborator

Add documentation for external access required by the charm.

Checklist

@Thanhphan1147 Thanhphan1147 added the trivial This is a trivial PR label May 3, 2024
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner May 3, 2024 09:20
yanksyoon
yanksyoon previously approved these changes May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

Test coverage for 8231fdc

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/actions.py         30      0      4      0   100%
src/agent.py          123      0     20      0   100%
src/auth_proxy.py      53      0      8      0   100%
src/charm.py           89      0     14      0   100%
src/cos.py             21      0      0      0   100%
src/ingress.py         17      0      4      0   100%
src/jenkins.py        375      0     60      0   100%
src/pebble.py          25      0      2      0   100%
src/state.py          110      0     24      0   100%
src/timerange.py       31      0      6      0   100%
---------------------------------------------------------------
TOTAL                 874      0    142      0   100%

Static code analysis report

Run started:2024-05-03 10:15:12.634510

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 7485
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 merged commit 20acfa2 into main May 3, 2024
2 of 11 checks passed
@Thanhphan1147 Thanhphan1147 deleted the document_external_access branch May 3, 2024 15:56
@Thanhphan1147
Copy link
Collaborator Author

Force merging this since we've decided that since this is a docs PR, it's relatively safe to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants