Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy slave integration #42

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Jan 30, 2024

Applicable spec: N/A

Overview

Remove legacy slave integration

Rationale

The legacy slave integration is not supported anymore by any other charm

Juju Events Changes

Removed events corresponding to the relation

Module Changes

Changes all across the charm

Library Changes

N/A

Checklist

@arturo-seijas arturo-seijas added the trivial This is a trivial PR label Jan 30, 2024
@arturo-seijas arturo-seijas requested a review from a team as a code owner January 30, 2024 12:04
Copy link
Contributor

Test coverage for 88cc078

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/agent.py         61      0     12      0   100%
src/charm.py         58      0     10      0   100%
src/metadata.py       9      0      0      0   100%
src/pebble.py        24      0      0      0   100%
src/server.py        51      0     12      0   100%
src/state.py         67      0     12      0   100%
-------------------------------------------------------------
TOTAL               270      0     46      0   100%

Static code analysis report

Run started:2024-01-30 12:06:20.974035

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1648
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit a443cfc into main Jan 30, 2024
19 checks passed
@arturo-seijas arturo-seijas deleted the remove-legacy-slave-relation branch January 30, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants