Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump juju, ops versions in ci and requirements files #402

Closed
wants to merge 16 commits into from
Closed

build: bump juju, ops versions in ci and requirements files #402

wants to merge 16 commits into from

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Apr 2, 2024 •
edited
Loading

Bumping juju and ops packages to use them in newer versions of the charms, plus testing them in a CI with a more recent juju version.

This commit also skips some test cases that will be removed in a follow up commit introduced by #401.

Part of canonical/bundle-kubeflow#859
Part of #398

Manual testing

  1. Install juju 3.4 and bootstrap a controller with the same version for the agent
  2. Deploy the charms resulting from this PR
  3. Execute commands like juju config istio-pilot default-gateway="some-name" and juju relate istio-pilot istio-ingressgateway
  4. Execute and upgrade from an earlier version of these charms from track/1.17

@DnPlas
build: bump juju, ops versions in ci and requirements files
5a4c8fd 
Bumping juju and ops packages to use them in newer versions of the charms,
plus testing them in a CI with a more recent juju version.

This commit also skips some test cases that will be removed in a follow
up commit introduced by #401.

Part of canonical/bundle-kubeflow#859
Part of #398

Signed-off-by: Daniela Plascencia <daniela.plascencia@canonical.com>
@DnPlas DnPlas marked this pull request as ready for review April 2, 2024 22:28
@DnPlas DnPlas requested a review from a team as a code owner April 2, 2024 22:28
@DnPlas DnPlas mentioned this pull request Apr 2, 2024
Merged
1 task
@DnPlas DnPlas mentioned this pull request Apr 2, 2024
Open
ca-scribner
ca-scribner reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for one comment

Do we expect the integration CI to fail here?

@DnPlas
Copy link
Contributor Author

DnPlas commented Apr 4, 2024

lgtm except for one comment

Do we expect the integration CI to fail here?

So far yes, I have added a comment here. I am experimenting some solutions to unblock us.

@DnPlas
Copy link
Contributor Author

DnPlas commented Apr 4, 2024 •
edited
Loading

I believe the CI was failing due to a mismatch in the versions that were deployed in these integration tests. This PR is attempting to bump the juju version, which also requires most packages to have a newer ops version to keep compatibility. For one reason or another, the versions of the charms that get deployed as dependencies of the testing framework were not updated, causing the issue we observed (for details, please refer to canonical/bundle-kubeflow#859 (comment)).
If everything goes well, #405 should fix the CI issues in this PR.

@DnPlas
Copy link
Contributor Author

DnPlas commented May 22, 2024

Closing as changes in this PR were introduced in #407 and will be introduced in #400

@DnPlas DnPlas closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-scribner ca-scribner ca-scribner left review comments

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DnPlas @ca-scribner