Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): Update README #81

Merged
merged 7 commits into from
Jan 10, 2025
Merged

chore(doc): Update README #81

merged 7 commits into from
Jan 10, 2025

Conversation

alithethird
Copy link
Contributor

@alithethird alithethird commented Dec 18, 2024

Applicable spec:

Overview

Rationale

Module Changes

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@alithethird alithethird added documentation Improvements or additions to documentation trivial labels Dec 18, 2024
@alithethird alithethird self-assigned this Dec 18, 2024
@alithethird alithethird requested a review from a team as a code owner December 18, 2024 09:36
@alithethird alithethird requested a review from erinecon December 18, 2024 09:38
README.md Outdated Show resolved Hide resolved
arturo-seijas
arturo-seijas previously approved these changes Dec 18, 2024
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! Only one comment from me :)

README.md Outdated Show resolved Hide resolved
Co-authored-by: Erin Conley <erin.conley@canonical.com>
arturo-seijas
arturo-seijas previously approved these changes Dec 19, 2024
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! I approve of the doc changes 👍
(Not giving an official approval as .trivyignore was changed in this PR)

@alithethird alithethird requested a review from cbartz December 20, 2024 05:58
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments.

.trivyignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 9, 2025

Test coverage for f9ecf91

Name                                                              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                                 0      0      0      0   100%
httprequest_lego_provider/apps.py                                     4      0      0      0   100%
httprequest_lego_provider/dns.py                                     68      0      4      0   100%
httprequest_lego_provider/forms.py                                   21      0      2      0   100%
httprequest_lego_provider/management/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/management/commands/__init__.py             0      0      0      0   100%
httprequest_lego_provider/management/commands/allow_domains.py       21      0      2      0   100%
httprequest_lego_provider/management/commands/create_user.py         14      0      0      0   100%
httprequest_lego_provider/management/commands/list_domains.py        22      0      4      0   100%
httprequest_lego_provider/management/commands/revoke_domains.py      21      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py                  8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/models.py                                   9      0      0      0   100%
httprequest_lego_provider/serializers.py                             24      0      0      0   100%
httprequest_lego_provider/urls.py                                     8      0      0      0   100%
httprequest_lego_provider/views.py                                   74      0     16      0   100%
-------------------------------------------------------------------------------------------------------------
TOTAL                                                               294      0     30      0   100%

Static code analysis report

Run started:2025-01-09 07:08:57.353125

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1715
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@alithethird alithethird requested review from cbartz and erinecon January 9, 2025 08:10
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! The updated version looks good to me, I approve 👍

(Not giving an official approval since .trivyignore was changed in this PR.)

@alithethird alithethird merged commit 6e33c9a into main Jan 10, 2025
18 checks passed
@alithethird alithethird deleted the update-readme branch January 10, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants