-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing User API (url, view, serializer, tests) #51
Conversation
/canonical/self-hosted-runners/run-workflows 4b0922e |
/canonical/self-hosted-runners/run-workflows 53a93a3 |
0644e32
to
22ad4ac
Compare
/canonical/self-hosted-runners/run-workflows 22ad4ac |
I've added myself as the reviewers, please feel free to ping me for the approval comment! @kot0dama Thank you for the PR! |
/canonical/self-hosted-runners/run-workflows 6a4bf58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment about the dash, thank you!
Signed-off-by: Loïc Gomez <89980752+kot0dama@users.noreply.github.com>
Fixed the GPG signature. |
/canonical/self-hosted-runners/run-workflows 7faaaf5 |
Test coverage for 7faaaf5
Static code analysis report
|
Thank you ! |
Overview
Add REST API route, view, serializer for Django auth.User model.
This code is untested yet as I have no local/testing environment for this project, but what I think would be enough for the needed API to become available. Please review carefully and perform the necessary edits, or raise them so I can fix them.
Rationale
We need to be able to list and create users through the REST API.
Checklist
urgent
,trivial
,complex
)This is neither urgent, trivial nor complex.