Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charm documentation #42

Merged
merged 11 commits into from
Mar 6, 2024
Merged

Add charm documentation #42

merged 11 commits into from
Mar 6, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Mar 5, 2024

Applicable spec: N/A

Overview

Charm documentation

Rationale

N/A

Module Changes

N/A

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@arturo-seijas arturo-seijas requested a review from a team as a code owner March 5, 2024 16:22
Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment inline, and also, should we maybe put the docs in the charms directory, as these are specific to the charm rather than the application?

docs/how-to/manage-domains.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Got a few nitpicks.

docs/how-to/manage-domains.md Outdated Show resolved Hide resolved
docs/how-to/manage-users.md Outdated Show resolved Hide resolved
@arturo-seijas arturo-seijas requested review from cbartz and mthaddon March 6, 2024 08:58
cbartz
cbartz previously approved these changes Mar 6, 2024
yanksyoon
yanksyoon previously approved these changes Mar 6, 2024
Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpicks, thank you!

charm/docs/how-to/manage-domains.md Outdated Show resolved Hide resolved
charm/docs/how-to/manage-users.md Show resolved Hide resolved
charm/docs/tutorials/getting-started.md Outdated Show resolved Hide resolved
@arturo-seijas arturo-seijas dismissed stale reviews from yanksyoon and cbartz via 2b713c1 March 6, 2024 09:31
arturo-seijas and others added 2 commits March 6, 2024 10:31
Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com>
Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com>
yanksyoon
yanksyoon previously approved these changes Mar 6, 2024
Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El gee tee em

Copy link

github-actions bot commented Mar 6, 2024

Test coverage for 3943adb

Name                                                              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                                 1      0      0      0   100%
httprequest_lego_provider/apps.py                                     5      0      0      0   100%
httprequest_lego_provider/dns.py                                     69      0      8      0   100%
httprequest_lego_provider/forms.py                                   22      0      2      0   100%
httprequest_lego_provider/management/__init__.py                      1      0      0      0   100%
httprequest_lego_provider/management/commands/__init__.py             1      0      0      0   100%
httprequest_lego_provider/management/commands/allow_domains.py       22      0      2      0   100%
httprequest_lego_provider/management/commands/create_user.py         14      0      0      0   100%
httprequest_lego_provider/management/commands/list_domains.py        16      0      2      0   100%
httprequest_lego_provider/management/commands/revoke_domains.py      22      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py                  8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/models.py                                  10      0      0      0   100%
httprequest_lego_provider/serializers.py                             11      0      0      0   100%
httprequest_lego_provider/urls.py                                     8      0      0      0   100%
httprequest_lego_provider/views.py                                   49      0      8      0   100%
-------------------------------------------------------------------------------------------------------------
TOTAL                                                               259      0     24      0   100%

Static code analysis report

Run started:2024-03-06 09:57:11.572382

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1385
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 4993570 into main Mar 6, 2024
13 checks passed
@arturo-seijas arturo-seijas deleted the docs branch March 6, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants