Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions to manage users and domains #40

Merged
merged 25 commits into from
Mar 5, 2024
Merged

Add actions to manage users and domains #40

merged 25 commits into from
Mar 5, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Mar 1, 2024

Applicable spec: https://docs.google.com/document/d/1J8LXOn8iQHC93OulsZB-PyL6c7iSjS_FPKZbZutPck0/edit

Overview

Add actions to manage users and domains

Rationale

Module Changes

charm.py
actions.py
management/commands/*

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

charm/src/actions.py Outdated Show resolved Hide resolved
charm/src/actions.py Outdated Show resolved Hide resolved
charm/src/actions.py Outdated Show resolved Hide resolved
charm/src/actions.py Outdated Show resolved Hide resolved
charm/src/actions.py Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 63 files.

Valid Invalid Ignored Fixed
23 4 36 0
Click to see the invalid file list
  • httprequest_lego_provider/management/commands/allow_domains.py
  • httprequest_lego_provider/management/commands/create_user.py
  • httprequest_lego_provider/management/commands/list_domains.py
  • httprequest_lego_provider/management/commands/revoke_domains.py

@canonical canonical deleted a comment from github-actions bot Mar 4, 2024
@canonical canonical deleted a comment from github-actions bot Mar 4, 2024
@canonical canonical deleted a comment from github-actions bot Mar 4, 2024
@canonical canonical deleted a comment from github-actions bot Mar 4, 2024
@arturo-seijas arturo-seijas marked this pull request as ready for review March 4, 2024 19:00
@arturo-seijas arturo-seijas requested a review from a team as a code owner March 4, 2024 19:00
charm/src/actions.py Outdated Show resolved Hide resolved
charm/src/actions.py Show resolved Hide resolved
charm/src/charm.py Outdated Show resolved Hide resolved
httprequest_lego_provider/tests/test_views.py Show resolved Hide resolved
Copy link

github-actions bot commented Mar 5, 2024

Test coverage for a400795

Name                                                              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                                 1      0      0      0   100%
httprequest_lego_provider/apps.py                                     5      0      0      0   100%
httprequest_lego_provider/dns.py                                     69      0      8      0   100%
httprequest_lego_provider/forms.py                                   22      0      2      0   100%
httprequest_lego_provider/management/__init__.py                      1      0      0      0   100%
httprequest_lego_provider/management/commands/__init__.py             1      0      0      0   100%
httprequest_lego_provider/management/commands/allow_domains.py       22      0      2      0   100%
httprequest_lego_provider/management/commands/create_user.py         14      0      0      0   100%
httprequest_lego_provider/management/commands/list_domains.py        16      0      2      0   100%
httprequest_lego_provider/management/commands/revoke_domains.py      22      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py                  8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/models.py                                  10      0      0      0   100%
httprequest_lego_provider/serializers.py                             11      0      0      0   100%
httprequest_lego_provider/urls.py                                     8      0      0      0   100%
httprequest_lego_provider/views.py                                   49      0      8      0   100%
-------------------------------------------------------------------------------------------------------------
TOTAL                                                               259      0     24      0   100%

Static code analysis report

Run started:2024-03-05 09:34:29.089234

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1385
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas requested a review from weiiwang01 March 5, 2024 11:38
@arturo-seijas arturo-seijas merged commit eafe65e into main Mar 5, 2024
13 checks passed
@arturo-seijas arturo-seijas deleted the add-actions branch March 5, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants