Remove trailing dot from the fqdn when present

[arturo-seijas]

Applicable spec: https://go-acme.github.io/lego/dns/httpreq/

Overview

Remove trailing dot from the fqdn when present, per the spec above

Rationale

N/A

Module Changes

forms.py

Checklist

• The contributing guide was applied
• The PR is tagged with appropriate label (urgent, trivial, complex)

[github-actions]

Test coverage for 9cc9018

Name                                                   Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                      1      0      0      0   100%
httprequest_lego_provider/apps.py                          5      0      0      0   100%
httprequest_lego_provider/dns.py                          58      0      8      0   100%
httprequest_lego_provider/forms.py                        22      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py       8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py           0      0      0      0   100%
httprequest_lego_provider/models.py                       10      0      0      0   100%
httprequest_lego_provider/serializers.py                  11      0      0      0   100%
httprequest_lego_provider/settings.py                      5      0      0      0   100%
httprequest_lego_provider/urls.py                          8      0      0      0   100%
httprequest_lego_provider/views.py                        49      0      8      0   100%
--------------------------------------------------------------------------------------------------
TOTAL                                                    177      0     18      0   100%

Static code analysis report

Run started:2024-02-27 09:22:09.647235

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 921
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

[weiiwang01]

Maybe we should consider saving fully qualified domain names with the trailing dot in the database, instead of stripping the trailing dot from the FQDN? In a zone file, a relative name (without a trailing dot) is considered an error unless concatenated with an origin. https://datatracker.ietf.org/doc/html/rfc1035#section-5.1

Of cause I might be wrong since I don't know if the same standard for DNS zone files should be apply to databases in httprequest-lego-provider.

[arturo-seijas]

Maybe we should consider saving fully qualified domain names with the trailing dot in the database, instead of stripping the trailing dot from the FQDN? In a zone file, a relative name (without a trailing dot) is considered an error unless concatenated with an origin. https://datatracker.ietf.org/doc/html/rfc1035#section-5.1

Of cause I might be wrong since I don't know if the same standard for DNS zone files should be apply to databases in httprequest-lego-provider.

Good point, however, what we'll be storing in the repo on a file per domain will be the subdomain with the challenge, for instance, for example.canonical.com well have a canonical.com file with the following content:
_acme_challenge.example 60 IN TXT [value as sent in the form]

We are just discarding the trailing dot since we have to support both formats, with, and without, as per to https://go-acme.github.io/lego/dns/httpreq/

[weiiwang01]

discarding the trailing dot since we have to support both formats

Understand, thanks for the explanation.