Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git username config option #18

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Add git username config option #18

merged 1 commit into from
Feb 1, 2024

Conversation

arturo-seijas
Copy link
Collaborator

Applicable spec:

Overview

Add git username config option

Rationale

Needed as per https://help.launchpad.net/Code/Git

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@arturo-seijas arturo-seijas requested a review from a team as a code owner February 1, 2024 11:56
Copy link

github-actions bot commented Feb 1, 2024

Test coverage for 2827d58

Name                                       Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py          1      0      0      0   100%
httprequest_lego_provider/apps.py              5      0      0      0   100%
httprequest_lego_provider/dns.py              61      0      8      0   100%
httprequest_lego_provider/forms.py            20      0      2      0   100%
httprequest_lego_provider/models.py           10      0      0      0   100%
httprequest_lego_provider/serializers.py      11      0      0      0   100%
httprequest_lego_provider/settings.py          6      0      0      0   100%
httprequest_lego_provider/urls.py              8      0      0      0   100%
httprequest_lego_provider/views.py            48      0      8      0   100%
--------------------------------------------------------------------------------------
TOTAL                                        170      0     18      0   100%

Static code analysis report

Run started:2024-02-01 11:58:06.771672

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 840
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturo-seijas arturo-seijas merged commit a6596a1 into main Feb 1, 2024
12 checks passed
@arturo-seijas arturo-seijas deleted the add-git-username branch February 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants