Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain endpoints #17

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Add domain endpoints #17

merged 7 commits into from
Jan 31, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Jan 29, 2024

Applicable spec: https://docs.google.com/document/d/1J8LXOn8iQHC93OulsZB-PyL6c7iSjS_FPKZbZutPck0

Overview

Add domains/ and domain-user-permissions/ endpoints

Rationale

The endpoints are needed to facilitate managing both the endpoints and the user endpoints matching programmatically from 3rd party systems

Module Changes

httprequest_lego_provider/urls.py
httprequest_lego_provider/serializers.py
httprequest_lego_provider/views.py

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@arturo-seijas arturo-seijas requested a review from a team as a code owner January 29, 2024 16:57
yanksyoon
yanksyoon previously approved these changes Jan 30, 2024
Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpicks :D

httprequest_lego_provider/serializers.py Show resolved Hide resolved
httprequest_lego_provider/tests/test_views.py Outdated Show resolved Hide resolved
httprequest_lego_provider/tests/test_views.py Show resolved Hide resolved
httprequest_lego_provider/views.py Outdated Show resolved Hide resolved
yanksyoon
yanksyoon previously approved these changes Jan 30, 2024
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have some comments

httprequest_lego_provider/urls.py Outdated Show resolved Hide resolved
httprequest_lego_provider/views.py Show resolved Hide resolved
httprequest_lego_provider/tests/test_views.py Outdated Show resolved Hide resolved
httprequest_lego_provider/tests/test_views.py Outdated Show resolved Hide resolved
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
Copy link

Test coverage for ee9b516

Name                                       Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py          1      0      0      0   100%
httprequest_lego_provider/apps.py              5      0      0      0   100%
httprequest_lego_provider/dns.py              59      0      8      0   100%
httprequest_lego_provider/forms.py            20      0      2      0   100%
httprequest_lego_provider/models.py           10      0      0      0   100%
httprequest_lego_provider/serializers.py      11      0      0      0   100%
httprequest_lego_provider/settings.py          5      0      0      0   100%
httprequest_lego_provider/urls.py              8      0      0      0   100%
httprequest_lego_provider/views.py            48      0      8      0   100%
--------------------------------------------------------------------------------------
TOTAL                                        167      0     18      0   100%

Static code analysis report

Run started:2024-01-31 09:34:36.951397

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 837
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 38af805 into main Jan 31, 2024
12 checks passed
@arturo-seijas arturo-seijas deleted the add-domain-endpoints branch January 31, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants