generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain endpoints #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanksyoon
previously approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor nitpicks :D
yanksyoon
previously approved these changes
Jan 30, 2024
cbartz
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but have some comments
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
yanksyoon
approved these changes
Jan 31, 2024
Test coverage for ee9b516
Static code analysis report
|
cbartz
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: https://docs.google.com/document/d/1J8LXOn8iQHC93OulsZB-PyL6c7iSjS_FPKZbZutPck0
Overview
Add
domains/
anddomain-user-permissions/
endpointsRationale
The endpoints are needed to facilitate managing both the endpoints and the user endpoints matching programmatically from 3rd party systems
Module Changes
httprequest_lego_provider/urls.py
httprequest_lego_provider/serializers.py
httprequest_lego_provider/views.py
Checklist
urgent
,trivial
,complex
)