Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Change description and add source to metadata #37

Merged
merged 22 commits into from
Apr 17, 2023
Merged

Change description and add source to metadata #37

merged 22 commits into from
Apr 17, 2023

Conversation

arturo-seijas
Copy link
Collaborator

Metadata changes to adapt to discourse as per https://discourse.charmhub.io/t/changes-to-charmhub-io-pages/9366

@arturo-seijas arturo-seijas requested a review from a team as a code owner April 10, 2023 11:14
gtrkiller
gtrkiller previously approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amandahla
Copy link
Contributor

Could you add *.rock to .gitignore?

@arturo-seijas
Copy link
Collaborator Author

*.rock

Could you add *.rock to .gitignore?

Done. Thanks

@arturo-seijas arturo-seijas requested a review from gtrkiller April 10, 2023 14:26
weiiwang01
weiiwang01 previously approved these changes Apr 11, 2023
View reviewed changes
nrobinaubertin
nrobinaubertin previously approved these changes Apr 11, 2023
View reviewed changes
@arturo-seijas arturo-seijas reopened this Apr 11, 2023
@arturo-seijas arturo-seijas dismissed stale reviews from nrobinaubertin and weiiwang01 via 29d3cc3 April 11, 2023 11:18
weiiwang01
weiiwang01 previously approved these changes Apr 11, 2023
View reviewed changes
@arturo-seijas arturo-seijas dismissed stale reviews from amandahla and gtrkiller via 925681f April 12, 2023 08:18
weiiwang01
weiiwang01 previously approved these changes Apr 12, 2023
View reviewed changes
gtrkiller
gtrkiller previously approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturo-seijas arturo-seijas reopened this Apr 12, 2023
@arturo-seijas arturo-seijas reopened this Apr 12, 2023
jdkandersson
jdkandersson reviewed Apr 13, 2023
View reviewed changes
.trivyignore Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
merkata
merkata previously approved these changes Apr 13, 2023
View reviewed changes
@arturo-seijas arturo-seijas dismissed stale reviews from merkata, gtrkiller, and weiiwang01 via 6069e19 April 14, 2023 10:30
@github-actions
Copy link
Contributor

Test coverage for 271a041

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     188      0     68      1    99%   248->250
----------------------------------------------------------
TOTAL            188      0     68      1    99%

Static code analysis report

Run started:2023-04-17 13:58:52.975952

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 882
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

amandahla
amandahla approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanksyoon
yanksyoon approved these changes Apr 17, 2023
View reviewed changes
Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/integration_test.yaml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@arturo-seijas arturo-seijas merged commit b05fe35 into main Apr 17, 2023
@arturo-seijas arturo-seijas deleted the change-description branch January 3, 2024 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdkandersson jdkandersson jdkandersson left review comments

@yanksyoon yanksyoon yanksyoon approved these changes

@amandahla amandahla amandahla approved these changes

@merkata merkata merkata left review comments

@nrobinaubertin nrobinaubertin Awaiting requested review from nrobinaubertin

@gregory-schiano gregory-schiano Awaiting requested review from gregory-schiano

@gtrkiller gtrkiller Awaiting requested review from gtrkiller

@weiiwang01 weiiwang01 Awaiting requested review from weiiwang01

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arturo-seijas @amandahla @merkata @nrobinaubertin @weiiwang01 @yanksyoon @jdkandersson @gtrkiller @gregory-schiano