-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross-model dashboards #29
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d29d1d3
Fix cross-model dashboards
rbarry82 6a19b3b
Use JInja <3.x, import Jinja at runtime so clients don't need it
rbarry82 8f18001
Make linters happy
rbarry82 08090ea
The consumer should work with multiple prometheuses
rbarry82 f936d31
Add a test for multiple monitoring targets
rbarry82 f8adda3
Make mypy quiet about jinja
rbarry82 d635d23
Make mypy quiet about jinja
rbarry82 08088d8
Magic dashboard discovery
rbarry82 b6f824d
Throw an exception and return if there are no prometheus relations
rbarry82 4ae2328
Handle upgrades
rbarry82 342461a
Fix charm upgrades
rbarry82 b8d6839
Final updates
rbarry82 1ebec13
Don't invalidate dashboards without monitoring
rbarry82 ddb6a98
Use the right lib version
rbarry82 719c06f
Fix stupid conversion error
rbarry82 f952deb
Merge branch 'main' into fix/cross-model-relations
rbarry82 a93b4e9
Merge branch 'fix/cross-model-relations' of github.com:rbarry82/grafa…
rbarry82 ca45110
Update tests
rbarry82 841b5f6
Make mypy quiet
rbarry82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
/venv | ||
*.py[cod] | ||
*.charm | ||
.flake8 | ||
tests | ||
tox.ini | ||
CONTRIBUTING.md | ||
INTEGRATING.md | ||
RELEASE.md | ||
Comment on lines
+7
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File comment: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no
.flake8
anymore