fix: update cos-tool permissions to adhere to cis hardening rules #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #208.
Solution
Fix the
cos-tool
permissions according to the linked issue (removing the write permission from others).Warning
I had to bump the
cos_agent
library because of a linting error which was auto-fixed bytox -e fmt
.We change the
cos-tool
permissions withpath.chmod(0o777)
in multiple places:We need three PRs in Prometheus, Loki and Grafana to fix those libraries:
I manually changed the library files, packed the charm, and tested with the
juju ssh grafana-agent/X -- sudo find / -xdev -type f -perm -002
command, and no file with too many permissions is returned anymore.Testing Instructions